Add per-project hashing salt

UCLH-Foundry / PIXL

PIXL Image eXtraction Laboratory

Apache License 2.0

8 stars 0 forks source link

Add per-project hashing salt #371

Closed milanmlft closed 3 months ago

milanmlft commented 3 months ago

Fixes #343

Use core.project_config.secrets.AzureKeyVault in hasher to set up Azure Key Vault connection
Hashing salts are now retrieved from the key vault, using the project-name as key
- If no salt exists, a new one is created and stored in the key vault
Removed the old hasher key vault functionality
Salt generation is moved into the hashing functionality, so only hasher knows about it

To do

[x] Wait until #366 gets merged into main before continuing

milanmlft commented 3 months ago

pixl_dcmd tests failing but will wait until #366 gets merged in before resolving.

milanmlft commented 3 months ago

Docs could definitely still use some further improvement.

milanmlft commented 3 months ago

Had to create a new secret in our dev Azure Keyvault under hasher--key to get system test passing. The Hasher API reads the secret configured with HASHER_API_AZ_KEY_VAULT_SECRET_NAME from the vault as key for the hashing. Added this to test/.env as well.