search

UCLH-Foundry / PIXL

PIXL Image eXtraction Laboratory
Apache License 2.0
8 stars 0 forks source link

Add DICOMweb uploader #379

Closed milanmlft closed 2 months ago

milanmlft commented 2 months ago

This adds the DicomWebUploader class to allow PIXL to take dicomweb as an alternative endpoint to upload DICOM files to.

Fixes #375

Dependencies

The new system test runs an extra project configured with dicomweb as its destination, but using the same input data as the original test project otherwise. This results in some ambiguous matches when querying the PIXL database as we're only querying on MRN and accession number. #380 should resolve that by including the project slug in the query.

jeremyestein commented 2 months ago

It might help to know about this new export-api (ehr-api) endpoint in my branch: https://github.com/UCLH-Foundry/PIXL/blob/347f25cf0ed463b0f4f1225b827084afc28f21e6/pixl_export/src/pixl_export/main.py#L90-L110 The orthanc-anon plugin now triggers the upload by calling this, rather than doing it itself. But I think as long as the API implementation gets the right uploader (which is what you'll be implementing for the DICOM upload route IIUC), then it'll be fine.

milanmlft commented 2 months ago

Making ready to review to run system tests (which will probably break)