UCLH-Foundry / PIXL

PIXL Image eXtraction Laboratory
Apache License 2.0
8 stars 0 forks source link

Don't expose ports on all interfaces unless needed #387

Closed jeremyestein closed 2 months ago

jeremyestein commented 2 months ago

Partially addresses #239 (fixing rather than auditing)

Most open ports only need to be accessed from the CLI that's running on the same host. So only listen on localhost.

Similar principal applies to running tests, although those usually won't be run in the hospital.

Orthanc raw and anon are a notable exception as someone may want to view those from the DSD or another hospital computer, but otherwise exposing everything to (perhaps) the whole hospital is a security hazard.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.97%. Comparing base (f9f5fae) to head (9089b94).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #387 +/- ## ======================================= Coverage 82.97% 82.97% ======================================= Files 79 79 Lines 3259 3259 ======================================= Hits 2704 2704 Misses 555 555 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.