UCLH-Foundry / PIXL

PIXL Image eXtraction Laboratory
Apache License 2.0
8 stars 0 forks source link

Enable renovate (further config to come) #391

Closed stefpiatek closed 1 month ago

stefpiatek commented 2 months ago

When this is enabled in main, renovate will create a PR containing further config for us to edit.

need to do the rest of the steps from the issue but should fix #153. Happy for someone else to pick up

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.84%. Comparing base (ee359da) to head (fe3636c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #391 +/- ## ========================================== - Coverage 83.38% 80.84% -2.55% ========================================== Files 80 76 -4 Lines 3304 3106 -198 ========================================== - Hits 2755 2511 -244 - Misses 549 595 +46 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jeremyestein commented 1 month ago

Attempting to install Renovate into the PIXL repo (as per https://github.com/apps/renovate ) I get the error This action must be performed by an organization owner.

Oddly, the app already appears to be installed (See https://github.com/UCLH-Foundry/PIXL/settings/installations ) although I don't have permission to configure it. But if it's already been installed there should be an "Onboarding PR" that it automatically generates (see https://github.com/renovatebot/tutorial?tab=readme-ov-file#part-2---onboarding ) which doesn't exist. So I don't know what has happened here.

paddyroddy commented 1 month ago

Without being an admin of that repo it is hard to tell but yes you need to install the app for that specific repo. Easiest way to double check is go to https://developer.mend.io/github/UCLH-Foundry and check it is listed, i.e.

image
jeremyestein commented 1 month ago

Thanks. Yes, it's listed. The job logs suggest it's in dry run mode though. Perhaps because it's pointing at main and the renovate config file is only in a different branch? The tutorial doesn't say anything about dry runs. Maybe this is in the settings I can't access?

INFO: Repository started
{
  "renovateVersion": "37.368.10"
}

INFO: DRY-RUN: Would commit files to onboarding branch
INFO: Dependency extraction complete
{
  "baseBranch": "main"
  "stats": {
    "managers": {
      "docker-compose": {
        "fileCount": 5,
        "depCount": 7
      },
      "dockerfile": {
        "fileCount": 6,
        "depCount": 6
      },
      "github-actions": {
        "fileCount": 1,
        "depCount": 12
      },
      "pep621": {
        "fileCount": 7,
        "depCount": 101
      }
    },
    "total": {
      "fileCount": 19,
      "depCount": 126
    }
  }
}

INFO: Repository finished
{
  "cloned": true
  "durationMs": 32106
}
paddyroddy commented 1 month ago

There needs to be some kind of @renovatebot config in the main branch. It should have made an onboarding PR - which would be automatically closed if you were to merge a config file in beforehand.

milanmlft commented 1 month ago

🚀 ❤️

paddyroddy commented 1 month ago

schedule:monthly is already set https://github.com/UCL-ARC/.github/blob/79d60db13e5b9c09843626dd242a4e69d2d056ec/renovate/default-config.json#L6