UCLH-Foundry / PIXL

PIXL Image eXtraction Laboratory
Apache License 2.0
8 stars 0 forks source link

Add in extra private tags for philips #406

Closed stefpiatek closed 3 weeks ago

stefpiatek commented 1 month ago

Feedback from Prostate MRI is that some public tags can have rounding issues, so including private tags. Not sure if its worth just creating a separate override for mri's as a whole?

closes https://github.com/UCLH-Foundry/the-rolling-skeleton/issues/245

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 83.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.24%. Comparing base (1104af1) to head (fcd501e).

Files Patch % Lines
...ixl_core/src/core/project_config/tag_operations.py 73.33% 4 Missing :warning:
..._core/src/core/project_config/pixl_config_model.py 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #406 +/- ## ========================================== + Coverage 83.23% 83.24% +0.01% ========================================== Files 78 78 Lines 3257 3265 +8 ========================================== + Hits 2711 2718 +7 - Misses 546 547 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.