Closed milanmlft closed 3 weeks ago
Attention: Patch coverage is 96.87500%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 83.04%. Comparing base (
1c356f2
) to head (b6ebc33
).
Files | Patch % | Lines |
---|---|---|
cli/src/pixl_cli/_docker_commands.py | 93.93% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Reverted back to using docker compose
directly in run-system-test.sh
because attempting to use pixl up/down
requires the following:
test/.env
to be set, because running the CLI through Python results in a series of imports and config()
calls, which will fail when the envvar is not setThere's a couple of workarounds for this, like temporarily copying over the test/.env
file to project root, or loading the test/.env
file through Python. But I'm going to leave it at this because this PR already took way too much time for what should have been a simple change ðŸ«
More importantly though, I think this points to some not-so-ideal design choices in the way we're handling these environment variables and .env
files. Because when I'm running pixl down
, I don't really care whether RABBITMQ_HOST
is defined or not, but at the moment that will result in an error. Might be worth having a think about!
Fixes #392
pixl dc
CLI command as a wrapper arounddocker compose
pixldc
Periphery changes:
pixl-db
envvars fororthanc-anon
cli._utils