search

UCLouvain-CBIO / depmap

Cancer Dependency Map package
https://uclouvain-cbio.github.io/depmap/
24 stars 7 forks source link

depmap_1.0 #2

Closed tfkillian closed 5 years ago

tfkillian commented 5 years ago

I still need to finish changing the output of the chucks in the vignette .rmd file before I knit the document for it. I will submit a pull request as soon as this is finished.

lgatto commented 5 years ago

Thank for the PR, Theo.

I would suggest that in the future, send a PR and ask for a review. That will make it easier to track and discuss changes. One general comment is coding style. Have a look here - while the guide refers to MSnbase specifically, I apply it across packages (for your functions in data_utils.R, feel free to use camel case though).

We will review the functions next time we meet and discuss the project.