refactor: rename arguments in `readSCP`

UCLouvain-CBIO / scp

Single cell proteomics data processing

https://uclouvain-cbio.github.io/scp/index.html

19 stars 2 forks source link

refactor: rename arguments in `readSCP` #17

Closed cvanderaa closed 3 years ago

cvanderaa commented 3 years ago

I think the quantTable should be renamed to featureTable as this table not only contains quantifications but also the metadata that will be stored in the rowData.

Similarly, metaTable is confusing as it could be feature metadata as well as sample metadata. We could simply rename metaTable to colData since in the end, the table will become the colData.

lgatto commented 3 years ago

I agree that naming that data feature is better. I am however unsure about the Table part. It can be a spread sheet, a data.frame, ... may be simply featureData?
A definitive yes for colData.

cvanderaa commented 3 years ago

Indeed, featureData sounds much better!

cvanderaa commented 3 years ago

Done by commit 0f08a4b328c478562d99066bb57929e703d3f71f