search

UCLouvain-CBIO / scp

Single cell proteomics data processing
https://uclouvain-cbio.github.io/scp/index.html
19 stars 2 forks source link

Deprecate `transferColDataToAssay` #18

Closed cvanderaa closed 3 years ago

cvanderaa commented 3 years ago

transferColDataToAssay should be removed since I think this can be confusing for new users and it will also promote messing up the colData. I used this function to extract assays along with their associated colData, but the getWithColData function from the MultiAssayExperiment package does the job!

lgatto commented 3 years ago

Yes, good idea!

cvanderaa commented 3 years ago

Do you think I should go through the deprecation process or can I just drop the function (and document it in NEWS.md)?

lgatto commented 3 years ago

The package is very recent, so it might not be too big of an offence to remove it silently.

cvanderaa commented 3 years ago

Done by commit https://github.com/UCLouvain-CBIO/scp/commit/2792311da2f852ad07922dfa3f33fecc6aefb862