search

UCSBCarpentry / 2019-04-11-UCSB-SW-Workshop

https://ucsbcarpentry.github.io/2019-04-11-UCSB-SW-Workshop/
Other
0 stars 0 forks source link

There are some broken image links #1

Closed dwangywu closed 5 years ago

dwangywu commented 5 years ago

Please delete the text below before submitting your contribution.

Thanks for contributing! If this contribution is for instructor training, please send an email to checkout@carpentries.org with a link to this contribution so we can record your progress. You’ve completed your contribution step for instructor checkout just by submitting this contribution.

If this issue is about a specific episode within a lesson, please provide its link or filename.

Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact Kate Hertweck (k8hertweck@gmail.com).

ilessing commented 5 years ago

At what URLs are you seeing broken images?

dwangywu commented 5 years ago

https://ucsbcarpentry.github.io/2019-04-11-UCSB-SW-Workshop/shell-novice/02-filedir/

On Tue, Mar 26, 2019 at 2:28 PM Ian Lessing notifications@github.com wrote:

At what URLs are you seeing broken images?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/UCSBCarpentry/2019-04-11-UCSB-SW-Workshop/issues/1#issuecomment-476859711, or mute the thread https://github.com/notifications/unsubscribe-auth/ArqA0jtLutty2KC7arnTksW9USSKZr0cks5vapDkgaJpZM4cMTfg .

ilessing commented 5 years ago

I did a right-click on one of the broken images and selected copy image address which gave me: https://ucsbcarpentry.github.io/2019-04-11-UCSB-SW-Workshop/shell-novice/fig/home-directories.svg The file doesn't exist in /shell-novice/fig/. I can see that file (home-directories.svg) exists already in 2019-04-11-UCSB-SW-Workshop/fig/ so we just need to correct the reference to go up 1 directory

The file reference is in _episodes/shell-novice/02-filedir.md at line number 110

change:

![Home Directories](../fig/home-directories.svg)

to:

![Home Directories](../../fig/home-directories.svg)

and now the home-directories.svg image does show up. (see screenshot) Now there are a bunch of other image references to fix. :-P

Screen-Shot-2019-03-27-at-12 01 26-PM
dwangywu commented 5 years ago

Many thanks!

Ian Lessing notifications@github.com 于 2019年3月27日 周三 12:06写道：

I did a right-click on one of the broken images and selected copy image address which gave me: https://ucsbcarpentry.github.io/2019-04-11-UCSB-SW-Workshop/shell-novice/fig/home-directories.svg The file doesn't exist in /shell-novice/fig/. I can see that file (home-directories.svg) exists already in 2019-04-11-UCSB-SW-Workshop/fig/ so we just need to correct the reference to go up 1 directory

The file reference is in _episodes/shell-novice/02-filedir.md at line number 110

change:

Home Directories

to:

Home Directories

and now the home-directories.svg image does show up. (see screenshot) Now there are a bunch of other image references to fix. :-P

[image: Screen-Shot-2019-03-27-at-12 01 26-PM] https://user-images.githubusercontent.com/275899/55104992-b42af800-5088-11e9-85f0-344d9beb791c.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/UCSBCarpentry/2019-04-11-UCSB-SW-Workshop/issues/1#issuecomment-477306975, or mute the thread https://github.com/notifications/unsubscribe-auth/ArqA0pXGKTNhluqImthjK5QPMw9IpYQFks5va8E5gaJpZM4cMTfg .

ilessing commented 5 years ago

I've corrected some more image references with e80765da34936. Are there any more broken images?

dwangywu commented 5 years ago

I will check it, if I found more, I will let you know.

Thanks!

Yuan

On Wed, Mar 27, 2019 at 4:05 PM Ian Lessing notifications@github.com wrote:

I've corrected some more image references with e80765d https://github.com/UCSBCarpentry/2019-04-11-UCSB-SW-Workshop/commit/e80765da349369bffa2d5af83fedf560e86c188e. Are there any more broken images?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/UCSBCarpentry/2019-04-11-UCSB-SW-Workshop/issues/1#issuecomment-477380290, or mute the thread https://github.com/notifications/unsubscribe-auth/ArqA0oRQQoN7jj6aRm0vOYXty1pkfPtvks5va_kpgaJpZM4cMTfg .

jonjab commented 5 years ago

Closing at our final prep meeting.