UCSBarchlab / PyRTL

A collection of classes providing simple hardware specification, simulation, tracing, and testing suitable for teaching and research. Simplicity, usability, clarity, and extensibility are the overarching goals, rather than performance or optimization.
http://ucsbarchlab.github.io/PyRTL
BSD 3-Clause "New" or "Revised" License
257 stars 78 forks source link

AES example not executable #379

Closed jemcmahan13 closed 3 years ago

jemcmahan13 commented 3 years ago

The example usage for the AES circuit (https://github.com/UCSBarchlab/PyRTL/blob/development/pyrtl/rtllib/aes.py) is in the comments of the file, rather than executable code. I think this has lead to some naming discrepancies between the example and the implementation; e.g. aes.encryption_statem is used in the example, but doesn't exist in the file (instead it's aes.encrypt_state_m).