A collection of changes that should make tox runs pass - Githubissues

UCSBarchlab / PyRTL

A collection of classes providing simple hardware specification, simulation, tracing, and testing suitable for teaching and research. Simplicity, usability, clarity, and extensibility are the overarching goals, rather than performance or optimization.

http://ucsbarchlab.github.io/PyRTL

BSD 3-Clause "New" or "Revised" License

253 stars 76 forks source link

A collection of changes that should make tox runs pass #425

Closed fdxmw closed 2 years ago

fdxmw commented 2 years ago

Various python 2/3 compatibility issues
_node_sort_keys were unstable when a wire and an output had the same name
Remove unnecessary sphinx version constraint (unsatisfiable under python2)
Remove basepython constraint to avoid a warning (tox will now use the same version of python to set up the test environment and run the tests)
Clean up pylint errors

tox passes with these changes on my system, hopefully these will also fix the github pull request checks.

$ uname
CYGWIN_NT-10.0-19043
$ tox -p
GLOB sdist-make: /usr/local/home/lauj/pyrtl/setup.py
✔ OK pycodestyle in 9.774 seconds
✔ OK py27-test in 1 minute, 52.48 seconds
✔ OK py37-test in 5 minutes, 50.654 seconds
  py37-test: commands succeeded
  py27-test: commands succeeded
  pycodestyle: commands succeeded
  congratulations :)