Closed fdxmw closed 1 year ago
I think all of this looks great! I'm torn between the old characters used for up/down in Utf8WaveRenderer
(link) (which match the transitions on binary signals) and the new ones you've chosen (which I find do make it easier to read). Just putting my two cents out there.
I'm torn between the old characters used for up/down in
Utf8WaveRenderer
(link) (which match the transitions on binary signals)
Thanks for taking a look! Can you help me understand how the old up/down characters matched the transitions on binary signals? For me the old characters didn't quite align, see the little bumps and gaps on screenshot, while the new characters seem to align for various fonts I've experimented with (screenshot)
Also this is all very subjective, I think these are improvements but I'm happy to make changes if people see things differently :)
Patch coverage: 96.03
% and project coverage change: -0.04
:warning:
Comparison is base (
bec4c37
) 90.51% compared to head (a9277d8
) 90.47%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I'm torn between the old characters used for up/down in
Utf8WaveRenderer
(link) (which match the transitions on binary signals)Thanks for taking a look! Can you help me understand how the old up/down characters matched the transitions on binary signals? For me the old characters didn't quite align, see the little bumps and gaps on screenshot, while the new characters seem to align for various fonts I've experimented with (screenshot)
Oh, sorry, I think I was looking at the wrong picture! Your new version looks much better, including those transitions. I’m 100% pro your changes. 😎
A number of updates to this pull request:
render_trace()
's segment_delim
and extra_line
options. extra_line
is now mandatory with two-line rendering for binary wires, and segment_delim
complicates the code and doesn't seem to be used.render_trace()
's default segment_size
to 1. I often find myself counting cycles between tick marks, and I find it's much easier to just read the cycle number from the ruler.
See the updated screenshots and tests for a preview:
extra_line
is enabled, draw additional major tick marks between signalssegment_delim
by default as the additional major ticks show roughly the same thing in less horizontal spaceAlso: