search

UCSBarchlab / PyRTL

A collection of classes providing simple hardware specification, simulation, tracing, and testing suitable for teaching and research. Simplicity, usability, clarity, and extensibility are the overarching goals, rather than performance or optimization.
http://ucsbarchlab.github.io/PyRTL
BSD 3-Clause "New" or "Revised" License
253 stars 76 forks source link

WireVector name setter unit test added #433

Closed TonyKorol1 closed 1 year ago

TonyKorol1 commented 1 year ago

Hello all! I am Tony Korol, a 3rd year EE major at UCSB, and this is my first time submitting a pull request for a PyRTL unit test. I chose to cover a simple case in wire.py which governs WireVector naming. The test code now includes the use case where a user may try to set the name of a WireVector to a non-string value. Ex: "x.name = 3" results in a PyrtlError.

TonyKorol1 commented 1 year ago

Hi Dr. Lau,

Thank you for the swift feedback and suggestions. I have made sure to follow them to my best ability, but please let me know if anything else stands out to you. I will keep these guidelines in mind for future pull requests. Thank you!

Tony K.