UCSC-MedBook / MedBook_

BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Make sample group from sample group & improve dataset picker #18

Open e-t-k opened 8 years ago

e-t-k commented 8 years ago

Couple of improvements for sample group creator:

-- The "add a data set" popup goes off screen when you have enough data sets (10 or so) and there's no obvious way to click the data set you need if it's off screen. (The non-obvious way is to add data sets you don't want until the target becomes visible, add that, then remove the others.)

-- Should be possible to select samples to include in a sample group by including (or filtering on) a different sample group.

e-t-k commented 7 years ago

User Story

I want to make a sample group of "All the AML samples in Compendium 2". I pick the Compendium 2 sample group; pick "filter by form values"; pick the "full compendium 2" clinical form.

I use the querybuilder to set disease=AML and submit.

The result is a sample group containing multiple data sets, with only the AML samples from each.

Changes necessary

(off the top of my head)

-- https://github.com/UCSC-MedBook/MedBook_/commit/872b65568e600bb7c58cd8f0f730b9eddbba9179 must be present so that each FQ sample ID in a sample group is unique -- allow user to pick sample groups when adding items to the new sample group -- when filtering these sample groups, use the fully qualified sample IDs

-- When importing clinical form, don't force it to be tied to a study but allow the sampleIDs to be fully qualified. this will allow a form to encompass an entire sample group.

mokolodi1 commented 7 years ago

@e-t-k and I discussed this and I'm going to make the following changes to sample groups:

Here's the whiteboard detailing my thoughts (and a couple of @e-t-k's) on this matter. 20161209_154705