UCSC-nanopore-cgl / nanopore-RNN

Collaboration repository with Nanopore Group
MIT License
0 stars 4 forks source link

Alignment #48

Closed ghost closed 6 years ago

ghost commented 6 years ago

An incredible number of changes from the master branch.

Too many things to cover but branches will be merged much quicker from now on.

Main differences are a move away from event based sequencing to signal. New labeled data structure. maximum expected accuracy alignment from SignalAlign event detection from Pypore and nanonet

codecov[bot] commented 6 years ago

Codecov Report

Merging #48 into master will decrease coverage by 5.32%. The diff coverage is 65.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   67.15%   61.82%   -5.33%     
==========================================
  Files           9        7       -2     
  Lines        1306     1881     +575     
==========================================
+ Hits          877     1163     +286     
- Misses        429      718     +289
Impacted Files Coverage Δ
nanotensor/utils.py 34.74% <33.33%> (-16.53%) :arrow_down:
nanotensor/alignedsignal.py 43.31% <43.31%> (ø)
nanotensor/fast5.py 47.12% <47.12%> (ø)
nanotensor/event_detection.py 86.27% <86.27%> (ø)
nanotensor/mea_algorithm.py 93.29% <93.29%> (ø)
nanotensor/error.py 51.85% <0%> (-7.41%) :arrow_down:
nanotensor/signalAlign-utils.py
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f298ba4...7382dbf. Read the comment docs.

ghost commented 6 years ago

Merging even though code coverage is lower than before. Need to start tracking work from master branch again.