UCSCLibrary / dams_project_mgmt

DAMS purpose is to provide access to digitized and born-digital UCSC Special Collections content. This repository is used for project planning. It holds the task tickets and roadmap for the different projects under DAMS.
2 stars 0 forks source link

Keyword searching from collection landing pages not working correctly #459

Open rmjaffe opened 3 years ago

rmjaffe commented 3 years ago

Descriptive Summary

Kate reported this issue via LibAnswers as follows: "When I navigate to a specific collection (such as Santa Cruz County Historical Photographs), a keyword search does not produce any results (or rather, the results list is the entire collection). But when I search a collection group (such as Santa Cruz County History Collections), the same keyword search produces results."

For example, From the landing page for the Santa Cruz County History Collections (https://digitalcollections.library.ucsc.edu/collections/sj139538x), I searched for 'surfing' and the system returned 8 results.

Screen Shot 2021-04-22 at 9 09 23 AM Screen Shot 2021-04-22 at 8 39 36 AM

However, when attempting the same keyword search, 'surfing', on the landing pages for any of the member collections, e.g. Vester Dick (https://digitalcollections.library.ucsc.edu/collections/p5547v91x), the system returns a result list inclusive of everything in that member collection.

Screen Shot 2021-04-22 at 9 10 32 AM Screen Shot 2021-04-22 at 8 40 04 AM

I saw the same pattern when keyword searching 'commencement' in the Campus history super-collection and then within the Eric Thiermann member collection.

Background

I'm wondering if this has something to do with how that super-collections/collection groups were set up in the system versus the collections. Despite both layers technically being collections, there are some disparities between the two as we've already seen with the metadata editing form.

Or it could be an issue with keyword searching using the search box that's part of the facet panel, because the same issue occurs with Harry Mayo which is not part of a super-collection, but has a collection landing page layout as the collections that are part of super-collections.

Screen Shot 2021-04-22 at 9 15 28 AM Screen Shot 2021-04-22 at 9 15 42 AM

Acceptance Criteria

This is what done looks like:

Expected Behavior

User is able to keyword search and return meaningful matches when searching within collections from collection landing pages.

Actual Behavior

System returns meaningless results, i.e. every work in the collection.

rmjaffe commented 3 years ago

@rschwab @JessWaggs Can you please look into this? I'm curious to get a better sense of what may be going on and what may be involved in correcting it.

DiemBTran commented 2 years ago

This passes Notch8 QA. See attached screen recording.

https://user-images.githubusercontent.com/29311858/144141117-b618ffc1-68c5-4a9a-b6eb-ceb73aa4b6cd.mp4

rmjaffe commented 2 years ago

This also looks good to me. @rschwab @JessWaggs Anything wanting?

rschwab commented 2 years ago

@snehagunduraoUL was this in the mega pull request from N8? I'm confused about this being in the 'code review' column, maybe I'm missing something.

snehagunduraoUL commented 2 years ago

@rschwab No..not this one. The one I tested was #479

sara-g commented 2 years ago

@rschwab We have not sent this code yet, but if everything looks good we can send it today. Same with 479.

rmjaffe commented 2 years ago

@snehagunduraoUL Would it make best sense to leave this in staging and to not push to production until after we've descoobied?

snehagunduraoUL commented 2 years ago

Yeah..that makes sense unless this is a high priority to be on production.

rmjaffe commented 2 years ago

@snehagunduraoUL It is a top priority, but if it's a ton of effort or if there's a good risk of scooby-related issues (i.e., more bugs), we should wait.

snehagunduraoUL commented 2 years ago

@sara-g what do you think?