[5] Deleting values using Bulkrax on import isn’t working

UCSCLibrary / dams_project_mgmt

DAMS purpose is to provide access to digitized and born-digital UCSC Special Collections content. This repository is used for project planning. It holds the task tickets and roadmap for the different projects under DAMS.

2 stars 0 forks source link

[5] Deleting values using Bulkrax on import isn’t working #521

Closed rschwab closed 2 years ago

rschwab commented 2 years ago

Descriptive Summary

As an admin user, I want to be able to use Bulkrax to delete values from fields.

Acceptance Criteria

This is what done looks like

[x] Importing with a blank value using numerated column headers for multi valued fields removes the value from the work.
[x] Other values are left in-tact on multi-valued fields
[x] Document functionality in Bulkrax Wiki

Expected Behavior

When using numerated columns in an import, if the cell is blank the value should be deleted.

bkiahstroud commented 2 years ago

@rschwab the acceptance criteria includes criteria for single valued fields, but I'm not actually seeing any single valued fields in the metadata schema. Do you have any recommendations for testing this?

rschwab commented 2 years ago

Wow you're right. Publisher was single valued but that's been commented out. I guess we'll skip this requirement for now, since there's no great way to test it.

bkiahstroud commented 2 years ago

Documentation for this has been added to the Bulkrax Wiki: link

bkiahstroud commented 2 years ago

@rschwab All my testing with this revealed no bugs, so I've gone ahead and pushed this back to Sandbox QA. Using the new documentation in the Bulkrax Wiki, can you test this when you get the chance?

rschwab commented 2 years ago

I just tested and this is still an issue. Imported using numerated columns with one value for genre deleted (see screenshot). After running this import, the two values are still present on the work, and present in the exporter created from the importer.

delete-bug

snehagunduraoUL commented 2 years ago

This works on sandbox now. Test data attached. test_521.csv Removed the value for genre_1 and the metadata on the importer has been updated successfully (the value is deleted). Exported csv also does not have the deleted value. importer : http://digitalcollections-staging-sandbox.library.ucsc.edu/importers/120?locale=en exporter : http://digitalcollections-staging-sandbox.library.ucsc.edu/exporters/8?locale=en @rschwab We can close this if the above QA desc makes sense to you. Thanks.

bkiahstroud commented 2 years ago

I just tested and this is still an issue. Imported using numerated columns with one value for genre deleted (see screenshot). After running this import, the two values are still present on the work, and present in the exporter created from the importer.

This ended up being an issue with controlled fields specifically due to special behavior coming from ScoobySnacks. With the changes from this PR, all controlled fields should now behave the same when importing/exporting as other non-controlled fields