UCSCLibrary / dams_project_mgmt

DAMS purpose is to provide access to digitized and born-digital UCSC Special Collections content. This repository is used for project planning. It holds the task tickets and roadmap for the different projects under DAMS.
2 stars 0 forks source link

(5) Undefined method `thumbnail_path' #540

Open rschwab opened 2 years ago

rschwab commented 2 years ago

This error happens when importing works with images using Bulkrax.

Steps to reproduce:

  1. Create an importer with values in the filename column that match image files
  2. Attach files using the 'Add Cloud files' button
  3. Visit a resulting work

Example work: http://digitalcollections-staging-sandbox.library.ucsc.edu/concern/works/k643b1207?locale=en Example work: http://digitalcollections-staging-sandbox.library.ucsc.edu/concern/works/nk322d35b?locale=en

Log output: I, [2022-05-24T11:52:09.219539 #4480] INFO -- : [b1d7ef92-059b-49c6-8c08-b5c4d06b1b98] Rendered collection of hyrax/base/_member.html.erb [6 times] (58.1ms) I, [2022-05-24T11:52:09.219631 #4480] INFO -- : [b1d7ef92-059b-49c6-8c08-b5c4d06b1b98] Rendered hyrax/base/_items.html.erb (88.1ms) I, [2022-05-24T11:52:09.219697 #4480] INFO -- : [b1d7ef92-059b-49c6-8c08-b5c4d06b1b98] Rendered hyrax/base/show.html.erb within layouts/hyrax/1_column (161.0ms) I, [2022-05-24T11:52:09.219906 #4480] INFO -- : [b1d7ef92-059b-49c6-8c08-b5c4d06b1b98] Completed 500 Internal Server Error in 231ms (ActiveRecord: 5.9ms) F, [2022-05-24T11:52:09.220796 #4480] FATAL -- : [b1d7ef92-059b-49c6-8c08-b5c4d06b1b98] F, [2022-05-24T11:52:09.220829 #4480] FATAL -- : [b1d7ef92-059b-49c6-8c08-b5c4d06b1b98] ActionView::Template::Error (undefined methodthumbnail_path' for # Did you mean? thumbnail_id): F, [2022-05-24T11:52:09.220935 #4480] FATAL -- : [b1d7ef92-059b-49c6-8c08-b5c4d06b1b98] 1: <%#= Customized from Hyrax 2.4.0 %> [b1d7ef92-059b-49c6-8c08-b5c4d06b1b98] 2: [b1d7ef92-059b-49c6-8c08-b5c4d06b1b98] 3: [b1d7ef92-059b-49c6-8c08-b5c4d06b1b98] 4: <%= render_thumbnail_tag member, {square: true} %> [b1d7ef92-059b-49c6-8c08-b5c4d06b1b98] 5: [b1d7ef92-059b-49c6-8c08-b5c4d06b1b98] 6: <%#= classes altered on this TD element %> [b1d7ef92-059b-49c6-8c08-b5c4d06b1b98] 7: <%= link_to(member.link_name, contextual_path(member, @presenter)) %> F, [2022-05-24T11:52:09.220965 #4480] FATAL -- : [b1d7ef92-059b-49c6-8c08-b5c4d06b1b98]
F, [2022-05-24T11:52:09.220982 #4480] FATAL -- : [b1d7ef92-059b-49c6-8c08-b5c4d06b1b98] app/helpers/ucsc_thumbnail_helper.rb:47:in ucsc_thumbnail_tag' [b1d7ef92-059b-49c6-8c08-b5c4d06b1b98] app/views/hyrax/base/_member.html.erb:4:in_app_views_hyrax_base__member_html_erb_774113954379727155_552980' [b1d7ef92-059b-49c6-8c08-b5c4d06b1b98] app/views/hyrax/base/_items.html.erb:17:in `_app_views_hyrax_baseitems_html_erb1379387083823296177_525300' [b1d7ef92-059b-49c6-8c08-b5c4d06b1b98] app/views/hyrax/base/show.html.erb:49:in `_app_views_hyrax_base_show_html_erb2207293767768189744_524220' `

rschwab commented 2 years ago

Here is the last commit to touch ucsc_thumbnail_helper.rb

rschwab commented 2 years ago

This error does not occur when manually creating a work and attaching a file via cloud files. Example: http://digitalcollections-staging-sandbox.library.ucsc.edu/concern/works/nv9352905?locale=en

bkiahstroud commented 2 years ago

@rschwab I'm unable to reproduce this locally or on sandbox. Here is an importer I successfully ran on sandbox following the instructions in the ticket's description.

Have you seen this on any other importers?

bkiahstroud commented 2 years ago

Oddly, I just got this error locally for an import that didn't have any files at all. The error makes it sound image-related, but maybe the error message is a red herring... I'll keep digging

bkiahstroud commented 2 years ago

Eureka! This error happens when navigating to a Work's show page that has a child Work who doesn't have a thumbnail. This PR has more details as well as a bug fix.

rschwab commented 2 years ago

Thanks, Kiah, that fixed the bug described in this ticket.