Audio does not play unless logged in

UCSCLibrary / ucsc-library-digital-collections

A rails app based on Hyrax to be used as a repository for UCSC library digital collections.

1 stars 2 forks source link

Audio does not play unless logged in #4

Closed NedHenry closed 6 years ago

NedHenry commented 7 years ago

Originally reported by: Susan Perry (Bitbucket: suep, GitHub: suep)

Hi Ned,

The audio player appears for each of the recordings, but clicking on the play button doesn't work unless I'm logged in. Let me know if you need more detail.

Thanks, Sue

Bitbucket: https://bitbucket.org/ethenry/ucsc-sufia-based-dams/issue/4

NedHenry commented 7 years ago

Original comment by Edward Henry (Bitbucket: ethenry, GitHub: ethenry):

I have resolved this simple but subtle bug that came from the default access control settings for filesets being very restrictive in a way that I hadn't seen before. I have added a few lines to our app/controllers/file_sets_controller.rb to explicit allow streaming access on this site. I will continue with further testing to make sure that it is still possible to rescind access if we set the permissions on these files to "private" later.

NedHenry commented 7 years ago

Original comment by Edward Henry (Bitbucket: ethenry, GitHub: ethenry):

This is a very important bug with access controls on the hydra_hls gem. I am adding it to the issues section of that gem's github site. I will leave it here as well, to make it easier to keep track of needed changes to this system.

Github issue on hydra_hls