[Bug]: `-r` flag no longer required in `install.sh`, still referenced in README.md

[ntlhui]

Commit Hash

a80fdcd19ec8a09245108a8341d1bce684fde8ac

Steps to Reproduce?

sudo ./install.sh -p /home/asm-data/anaconda3/envs/asm_dep/bin/python -r /home/asm-data/anaconda3/envs/asm_dep/bin/runServer.py

Observed Behavior

(asm_dep) asm-data@e4e-brix:~/ASM-data-server$ sudo ./install.sh -p /home/asm-data/anaconda3/envs/asm_dep/bin/python -r /home/asm-data/anaconda3/envs/asm_dep/bin/runServer.py
[sudo] password for asm-data:
./install.sh usage:
    -d            Specify debug
    -p python     Specify python interpreter
    -r runServer  Specify runServer.py location
    -h            Display this message
WARNING: The directory '/home/asm-data/.cache/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Processing /home/asm-data/ASM-data-server
Requirement already satisfied: PyYAML in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from ASM-DataServer==0.0.0.1) (5.4.1)
Requirement already satisfied: asm_protocol in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from ASM-DataServer==0.0.0.1) (0.0.0.1)
Requirement already satisfied: appdirs in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from ASM-DataServer==0.0.0.1) (1.4.4)
Requirement already satisfied: pytest in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from ASM-DataServer==0.0.0.1) (6.2.5)
Requirement already satisfied: AsmCommon in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from ASM-DataServer==0.0.0.1) (0.0.0.1)
Requirement already satisfied: numpy in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from asm_protocol->ASM-DataServer==0.0.0.1) (1.21.2)
Requirement already satisfied: attrs>=19.2.0 in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from pytest->ASM-DataServer==0.0.0.1) (21.4.0)
Requirement already satisfied: importlib-metadata>=0.12 in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from pytest->ASM-DataServer==0.0.0.1) (4.8.1)
Requirement already satisfied: toml in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from pytest->ASM-DataServer==0.0.0.1) (0.10.2)
Requirement already satisfied: pluggy<2.0,>=0.12 in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from pytest->ASM-DataServer==0.0.0.1) (1.0.0)
Requirement already satisfied: iniconfig in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from pytest->ASM-DataServer==0.0.0.1) (1.1.1)
Requirement already satisfied: packaging in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from pytest->ASM-DataServer==0.0.0.1) (21.3)
Requirement already satisfied: py>=1.8.2 in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from pytest->ASM-DataServer==0.0.0.1) (1.11.0)
Requirement already satisfied: typing-extensions>=3.6.4 in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from importlib-metadata>=0.12->pytest->ASM-DataServer==0.0.0.1) (3.10.0.2)
Requirement already satisfied: zipp>=0.5 in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from importlib-metadata>=0.12->pytest->ASM-DataServer==0.0.0.1) (3.6.0)
Requirement already satisfied: pyparsing!=3.0.5,>=2.0.2 in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from packaging->pytest->ASM-DataServer==0.0.0.1) (3.0.6)
Building wheels for collected packages: ASM-DataServer
  Building wheel for ASM-DataServer (setup.py) ... done
  Created wheel for ASM-DataServer: filename=ASM_DataServer-0.0.0.1-py3-none-any.whl size=9867 sha256=8d60bd223918f5c1d1be212ed855a1fa0379d74a3f1fe23ea21197b5725f50c1
  Stored in directory: /tmp/pip-ephem-wheel-cache-9w_h1mdq/wheels/0b/48/30/ba718ef2f33d9ad83982bcada1a3364b36b67f14796b4fd8c2
Successfully built ASM-DataServer
Installing collected packages: ASM-DataServer
  Attempting uninstall: ASM-DataServer
    Found existing installation: ASM-DataServer 0.0.0.1
    Uninstalling ASM-DataServer-0.0.0.1:
      Successfully uninstalled ASM-DataServer-0.0.0.1
Successfully installed ASM-DataServer-0.0.0.1
cp: cannot create regular file '/usr/local/etc/ASMDataServer/asm_config.yaml': No such file or directory
Created symlink /etc/systemd/system/multi-user.target.wants/asm_server.service → /lib/systemd/system/asm_server.service.
(asm_dep) asm-data@e4e-brix:~/ASM-data-server$ 

Desired Behavior

No usage message, no cp failure

Component

Server

Relevant Sensor Node log output

No response

Relevant Sensor Node configuration

No response

Relevant Server log output

No response

Relevant Server configuration

No response

[ntlhui]

Note that this also failed to create /usr/local/etc/ASMDataServer

[ntlhui]

Recommend changing install procedure to use setup.py.