UCSD-E4E / smartfin-fw2

Smartfin FW 2
GNU General Public License v3.0
1 stars 0 forks source link

Firmware does not report version to the cloud #33

Closed ntlhui closed 2 years ago

ntlhui commented 2 years ago

Describe the bug The Firmware does not currently report FW to the cloud

To Reproduce Steps to reproduce the behavior:

  1. Go to console.particle.io
  2. Find the corresponding device
  3. Check the Firmware column

Expected behavior This column should report the internal FW Version

Screenshots image

Hardware Configuration(please complete the following information):

Additional context Also applies to all facture_ph1 devices

ntlhui commented 2 years ago

Add PRODUCT_ID(8977) Add PRODUCT_VERSION(FW_MAJOR_VERSION << 8 | FW_MINOR_VERSION)

ntlhui commented 2 years ago

Note that the Product Version is a 16-bit value.

We currently have Major, Minor, Patch, and Build.

if we allocate 4 bits to each field, this gives us 16 of each.

Recommend we drop the patch version, and keep major, minor, and build in FW. Cloud will report minor and build, minor in the upper byte and build in the lower byte.

ntlhui commented 2 years ago
Position Bit Width Field Range
13 3 Major Version 7
7 6 Minor Version 63
0 7 Build Number 127