UCSD-E4E / smartfin-fw2

Smartfin FW 2
GNU General Public License v3.0
1 stars 0 forks source link

GPS outputs too much data #47

Closed ntlhui closed 2 years ago

ntlhui commented 2 years ago

Describe the bug During surf session init state, GPS outputs too much information

To Reproduce Steps to reproduce the behavior:

  1. Load v2.0.0.9
  2. Short W/D sensor in GPS permissive environment
  3. Wait for GPS

Expected behavior GPS output should not clobber CLI

Hardware Configuration(please complete the following information):

ntlhui commented 2 years ago

Suggested patch:

diff --git a/src/ride.cpp b/src/ride.cpp
index 1c4206f..5759690 100644
--- a/src/ride.cpp
+++ b/src/ride.cpp
@@ -139,7 +139,6 @@ STATES_e RideInitTask::run(void)
             pSystemDesc->pGPS->encode(GPS_getch());
         }

-        RIDE_setFileName(millis());

         if((pSystemDesc->pGPS->location.age() < GPS_AGE_VALID_MS) && (pSystemDesc->pGPS->location.age() >= 0))
         {
@@ -184,6 +183,7 @@ STATES_e RideInitTask::run(void)

 void RideInitTask::exit(void)
 {
+    RIDE_setFileName(millis());
     this->ledStatus.setActive(false);
 }