Never mix `scrapeQualifiers` into cons-gen

UCSD-PL / refscript

Refinement Types for Scripting Languages

BSD 3-Clause "New" or "Revised" License

65 stars 3 forks source link

Never mix `scrapeQualifiers` into cons-gen #11

Closed ranjitjhala closed 10 years ago

ranjitjhala commented 10 years ago

We should not be mixing scrapeQualifiers into constraint generation, that should be a strictly external and heuristic process. In other words, scrapeQualifiers should not ever be (transitively) called from consNano and code like:

consCall g l fn es ft0 
  = do (xes, g')    <- consScan consExpr g es
       -- Attempt to gather qualifiers here -- needed for object literal quals
       ts           <- mapM scrapeQualifiers [envFindTy x g' | x <- xes]

should be undone.

panagosg7 commented 10 years ago

This is fixed by PR #16

ranjitjhala commented 10 years ago

Awesome, thanks!

On Mon, Sep 1, 2014 at 7:55 PM, Panagiotis Vekris notifications@github.com wrote:

Closed #11 https://github.com/UCSD-PL/RefScript/issues/11.

Reply to this email directly or view it on GitHub https://github.com/UCSD-PL/RefScript/issues/11#event-159787637.

Ranjit.