search

UCSD-PL / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
0 stars 7 forks source link

Escape reveals all variables in PB on the web version #35

Open rlisahuang opened 1 year ago

rlisahuang commented 1 year ago

Suspect: race condition with some action also handled by Escape in RTV

rlisahuang commented 1 year ago

The source of the problem is that in the web version, ViewMode is still set to Full despite that ModVars is set to true by default, while in the local version ViewMode is set to Custom. This discrepancy causes pressing Escape in the web version to accidentally bring out all variables in PB instead of cancelling the code suggestion insertion.

More investigation is needed to fully resolve this issue. For now I did a simple hack -- tell PB that "leap is on" when Leap is constructed to avoid all keydown handling of Escape in PB.

Fix in https://github.com/UCSD-PL/vscode/commit/77ea8cc1a4501059a1db3d654a4e5a75ee5cd50b