UCSD / campus-mobile

Mobile App for Campus
MIT License
60 stars 100 forks source link

Authenticated cards reactivated after re-login or reinstall #827

Open c3bryant opened 4 years ago

c3bryant commented 4 years ago

Time Tracking: MA-80

This is done when:

Issue Update (12-20-2021):

Encountered more issues in prod. Besides not saving the card order, the app does not save the user's (Student or Staff) card states (i.e. whether a card is hidden or not).

Issue Update (12-17-2021):

While encountering bugs when creating a fix for the issue, I came upon an issue in production for Employee and Student Accounts:

  1. Log in as an Employee or Student
  2. Move a card to:
    • The top 1-3 positions for Employee
    • 1 - 3/4 positions below 'MyStudentChart' for Student
  3. Remove the app from memory
  4. Open the app
  5. The re-ordered card will have been pushed down from the spot you moved it to

Issue Update (10-11-2021):

Upon further testing, it seems that the card ordering is preserved so long as the user is logged into the app. If the user logs out then logs back in, the cards go back to the default ordering. Thus, there may be an issue with the app not saving the users' card preferences to their remote profiles.

Issue Previous:

All authenticated cards are set to be rendered beneath the MyChart card. This behavior was added purposely when few cards were available for activation on replatform V1.

With the addition of more cards, this change is now causing a bug preventing authenticated cards like Student ID, Classes, and Finals to not appear in the order the user has specified in Cards->Profile

gmihir commented 2 years ago

When trying to reorder cards and trying various network states (no internet, disconnect/reconnect, etc.), the app gets stuck on a "No Internet" screen even though it is currently connected to the Internet. The only way to recover from this screen is to press the "Ok" button 4-5 times (weirdly, the background starts at black and every time the Ok button is pressed, brightens).

Besides this, the card reordering and persistence was looking good.

Screen Shot 2022-03-15 at 6.27.55 PM.pngScreen Shot 2022-03-15 at 6.27.52 PM.png

keskinmbaha commented 2 years ago

I saw this issue happen on experimental as well so I had made an issue for it #1749. Not sure if I should try to fix the issue with this PR or make a new branch/PR for #1749.

c3bryant commented 2 years ago

Encountered a bug in 7.19 regression testing which traced back to PR #1750

Hiding cards on the Home view is not working as expected.

c3bryant commented 1 year ago

Moving to backlog until Transition to Flutter Hooks/FQuery #1918 is complete.