UCTRONICS / SKU_RM0004

Raspberry Pi NAS Cluster/Raspberry Pi SATA Cluster
50 stars 32 forks source link

IP address defaults to wlan (might be more useful to default to eth0) #4

Closed geerlingguy closed 2 years ago

geerlingguy commented 2 years ago

I just realized after reading through #2 and also seeing @TiVoHomeUser's fork (https://github.com/UCTRONICS/SKU_RM0004/compare/main...TiVoHomeUser:SKU_RM0004:main), that the default for the IPADDRESS_TYPE is currently set to WLAN0_ADDRESS:

https://github.com/UCTRONICS/SKU_RM0004/blob/0e0f0cec9847d66f91de0572c2c3c16515b7f71c/hardware/rpiInfo/rpiInfo.h#L14

That means my Pis, which are connected via wired network, aren't able to show their IP address.

I think for the rackmount unit, most people will be plugging in wired Ethernet, so it might make sense to default that value to ETH0_ADDRESS like @TiVoHomeUser does.

geerlingguy commented 2 years ago

I created a pull request for this change: https://github.com/UCTRONICS/SKU_RM0004/pull/5