search

UDC-GAC / pRIblast

pRIblast is a high efficient, parallel application for extensive lncRNA-RNA interaction analysis
https://doi.org/10.1016/j.future.2022.08.014
MIT License
2 stars 0 forks source link

Possible loss of performance due to passing two vectors by value to a method which is run in a computation heavy loop #4

Closed amatria closed 2 years ago

amatria commented 2 years ago

https://github.com/UDC-GAC/pRIblast/blob/81b9efaa583476a4ffae67675e87e1eb44732b04/src/seed_search.cpp#L101-L107

TODO:

  1. Check there indeed exists an important penalty because of passing these two vectors by value.
  2. Edit the code and pass the two vectors by reference.
  3. Benchmark and submit a PR, if necessary.