search

UDST / bayarea_urbansim

UrbanSim implementation for the San Francisco Bay Area
14 stars 26 forks source link

misaligned lookup table values? #42

Closed mkreilly closed 9 years ago

mkreilly commented 9 years ago

@janowicz: So, I think I may be getting an idea of devtypes and devids and where they all get set up in spandex. And I think I found "the problem" at: https://github.com/synthicity/bayarea_urbansim/blob/master/data_regeneration/match_aggregate.py#L780-L781

The crosswalk coding here deviates from the codes I set up. I think this wrong unless it’s been done consistently this other way somewhere else. But Fletcher did mention seeing a lot of transport parcels (which I think are supposed to be vacant ones). So the correct look up to match the codes I specified is (others look right): VA 21 PG 22 PL 23 TR 24 LD 25

I'm a little scared of trying to change anything bc spandex still confuses me a bit. Thanks!

mkreilly commented 9 years ago

also the TR (in my codes) has been named AP. Not sure if that convention happened elsewhere.

janowicz commented 9 years ago

Good catch, Mike. Thanks for the correction, will update. I was trying to follow the coding here, but must have made typos: https://github.com/MetropolitanTransportationCommission/rtp-2017-urbansim-inputs/blob/master/bldgtypes.csv

On Tue, May 26, 2015 at 3:42 PM, Michael Reilly notifications@github.com wrote:

@janowicz https://github.com/janowicz: So, I think I may be getting an idea of devtypes and devids and where they all get set up in spandex. And I think I found "the problem" at:

https://github.com/synthicity/bayarea_urbansim/blob/master/data_regeneration/match_aggregate.py#L780-L781

The crosswalk coding here deviates from the codes I set up. I think this wrong unless it’s been done consistently this other way somewhere else. But Fletcher did mention seeing a lot of transport parcels (which I think are supposed to be vacant ones). So the correct look up to match the codes I specified is (others look right): VA 21 PG 22 PL 23 TR 24 LD 25

I'm a little scared of trying to change anything bc spandex still confuses me a bit. Thanks!

— Reply to this email directly or view it on GitHub https://github.com/synthicity/bayarea_urbansim/issues/42.

mkreilly commented 9 years ago

yeah it's mostly in line with that until near the end when it gets out of line. Hopefully will increase capacity.

janowicz commented 9 years ago

Corrected now: https://github.com/synthicity/bayarea_urbansim/commit/88d2c0345a4a2bde888557e7054c9578d65c8706

Thanks for catching.