search

UDST / choicemodels

Python library for discrete choice modeling
https://udst.github.io/choicemodels
BSD 3-Clause "New" or "Revised" License
74 stars 33 forks source link

Add test statistics to mnl #31

Closed Arezoo-bz closed 6 years ago

Arezoo-bz commented 6 years ago

This PR closes issue #28.

screen shot 2018-06-29 at 10 47 36
coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.4%) to 52.399% when pulling 531423e3b0c9c258e280e3cfeccba60151189bc5 on arezoo into 55054279c2ec1eaf2791764dadc0eff14c9cad32 on master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.4%) to 52.399% when pulling 531423e3b0c9c258e280e3cfeccba60151189bc5 on arezoo into 55054279c2ec1eaf2791764dadc0eff14c9cad32 on master.

Eh2406 commented 6 years ago

Glad to see this added! Should it also get back ported to the original urbansim copy of this code?

smmaurer commented 6 years ago

@Arezoo-bz This is fantastic!! So great to have all of this

@Eh2406 It shouldn't take much surgery for the current version of urbansim to display a table like this -- i'll open up an issue in that repo

smmaurer commented 6 years ago

@Arezoo-bz We should figure out why the Travis build is failing before merging this, though -- it looks like a real error, but only in Python 3.6 for some reason. I can help diagnose this on Monday.

gboeing commented 6 years ago

@smmaurer @Arezoo-bz CI test failure fixed in #34