[0.2.dev1] Improve MNL estimation reliability

UDST / choicemodels

Python library for discrete choice modeling

https://udst.github.io/choicemodels

BSD 3-Clause "New" or "Revised" License

74 stars 33 forks source link

[0.2.dev1] Improve MNL estimation reliability #36

Closed smmaurer closed 6 years ago

smmaurer commented 6 years ago

This PR replicates the fixes from https://github.com/UDST/urbansim/pull/211.

reduces likelihood of matrix overflow by rescaling the utilities before exponentiating them
warns the user if scipy.optimize.fmin_l_bfgs_b reports not converging correctly

Versioning

updates choicemodels version number to 0.2.dev1

coveralls commented 6 years ago

Coverage increased (+0.1%) to 52.545% when pulling e7ec8a1e12c7fee827c1a53cab73675002a79a08 on fix-runtime-overflow into 809ed5e58b69ab5b8e11c914598cffc5d7e994c3 on master.