search

UDST / developer

Redesigned UrbanSim developer/pro forma models
https://udst.github.io/developer/
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

SqFtProForma.from_yaml() missing many of the fields specified in proforma.yaml() #35

Closed mxndrwgrdnr closed 7 years ago

mxndrwgrdnr commented 7 years ago

Specifically, only_built, parcel_filter, residential_to_yearly, forms_to_test, pass_through, and simple_zoning seem to be missing from the class method. SqFtProForma.get_defaults() appears to be fully specified, so just making sure there's parity between these two functions should do the trick.

pksohn commented 7 years ago

Good catch. I'll get to this tomorrow. Since these are optional parameters, we need to make sure we handle cases where any or all of these parameters are missing from the YAML config.

pksohn commented 7 years ago

Fixed in #36.