search

UDST / orca

Python library for task orchestration
https://udst.github.io/orca/
BSD 3-Clause "New" or "Revised" License
53 stars 21 forks source link

Fixes the hdf output so that the results of the 1st iteration of the run is output to the store in addition to the base tables #10

Closed bridwell closed 8 years ago

bridwell commented 8 years ago

This addresses #9.

bridwell commented 8 years ago

I think the column assertion errors are independent of the change in this request.

But this does alter the the tables that are output for cases where the _outinterval is not 1. So in the test, the run is iterating over 0 to 10. Previously this would output tables for base, iterations 3,6,9 and final (10). With this change, base and final tables are still output but iterations 2,5,8 are output instead (hence the failed test).

I think the 2,5,8 is probably the result I would expect, so it seems like the test should be updated to reflect this?

jiffyclub commented 8 years ago

Sounds good. This may also require updating the docstring and documentation to make the underlying logic clear.

bridwell commented 8 years ago

Is there a particular reason why the last year is written out as 'final' if it doesn't fall in the intervals but written with its iter_var if it does? Would it be more consistent to use the iter_var as the start of the name in both cases? Or does that break other things?

jiffyclub commented 8 years ago

That's probably an oversight. Adding iter_var to the final name makes sense, or you could use only iter_var as the final name.