search

UDST / orca

Python library for task orchestration
https://udst.github.io/orca/
BSD 3-Clause "New" or "Revised" License
53 stars 21 forks source link

Update to_frame() behavior for columns=[] #31

Closed pksohn closed 7 years ago

pksohn commented 7 years ago

Addresses #30. This simple change enables the behavior we're looking for: now upon passing an empty list to the columns parameter of to_frame(), a DataFrame with the appropriate index, but no columns, should be returned. This equivalent to calling df[[]].

@Eh2406 you might want to take a look.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.002%) to 96.594% when pulling 08be77a759dd598bc6fccfd93a72ddf02b269696 on empty_list into 2842ae01e1d314fcee06a8ba5f90ab31ab3e1393 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.002%) to 96.594% when pulling 08be77a759dd598bc6fccfd93a72ddf02b269696 on empty_list into 2842ae01e1d314fcee06a8ba5f90ab31ab3e1393 on master.

Eh2406 commented 7 years ago

Yes! That looks perfect!