search

UDST / orca

Python library for task orchestration
https://udst.github.io/orca/
BSD 3-Clause "New" or "Revised" License
53 stars 21 forks source link

Orca breaks with toolz>=0.11, because tz.compatibility.zip is depreciated #50

Closed MaxBo closed 3 years ago

MaxBo commented 4 years ago

if toolz>=0.11 is installed, an error is raised in orca.py in line 940,

labels_map = dict(tz.concatv( tz.compatibility.zip(names[:offset], names[:offset]), tz.compatibility.zip(names[offset:], expressions))) because tz.compatibility.zip does is not supported any more from toolz>=0.11. With tools==0.10 it still works.

You could either switch to the standard library zip instead of tz.compatibility.zip , or if you need this for compability reasons with python 2, pin the toolz-version to 0.10.

smmaurer commented 4 years ago

Hi @MaxBo, thanks for catching this! It should be fixed now in the toolz-patch branch, and we'll put out a release as soon as we do a little more testing.

Here's the code on the toolz side, for future reference: https://github.com/pytoolz/toolz/blob/master/toolz/compatibility.py

Incidentally, it looks like toolz.compatibility is just supposed to raise a DeprecationWarning beginning in v0.11, which is what happens on my Mac. But in one of our Linux environments it raised an error, likely the same as what's described above -- an AttributeError on importing tlz.compatibility. The fix I implemented is to switch to the standard library zip, which should solve things either way.

cvanoli commented 3 years ago

I've encountered the same issue. Hope this fix gets pushed in soon. Thanks Sam!

smmaurer commented 3 years ago

Resolved in v1.5.4 release / PR #53