search

UDST / orca

Python library for task orchestration
https://udst.github.io/orca/
BSD 3-Clause "New" or "Revised" License
53 stars 21 forks source link

use sets instead of lists in to_frame for clarity #7

Closed Eh2406 closed 7 years ago

Eh2406 commented 8 years ago

Also better O: O(len(self.local.columns) * len(columns) * len(extra_cols)) => O(len(self.local.columns) + len(columns) + len(extra_cols))

Eh2406 commented 7 years ago

I know this is very small. Do you like it? If not why not? Who can merge?

As always just starting a discussion, and willing to help implement any fix.

fscottfoti commented 7 years ago

I'm ok with it. I'm not sure it's more clear than lists just in the sense that most people don't use set operations a ton...

janowicz commented 7 years ago

Looks fine to me. Though the list comprehension is a tad easier for me to comprehend at first glance since I don't use set operations as often. I do like not having to look up tz.keyfilter :).

fscottfoti commented 7 years ago

Yeah tz.keyfilter is a weird one. Maybe we should all start using set operations ;)

janowicz commented 7 years ago

Works for me :)