Fixing matplotlib backend

UDST / pandana

Pandas Network Analysis by UrbanSim: fast accessibility metrics and shortest paths, using contraction hierarchies :world_map:

http://udst.github.io/pandana

GNU Affero General Public License v3.0

387 stars 83 forks source link

Fixing matplotlib backend #135

Closed smmaurer closed 4 years ago

smmaurer commented 4 years ago

This PR resolves issue #132, where a hardcoded Matplotlib setting was creating problems for downstream code. As far as I can tell, the setting was just an old attempt to make Travis tests run more smoothly and is no longer needed.

Testing

Confirmed that this fixes the problem, as described here: https://github.com/UDST/pandana/issues/132#issuecomment-638395255

coveralls commented 4 years ago

Coverage decreased (-0.02%) to 91.651% when pulling 09167d2805fc6183a9ee0d30f41fbfe37a3e5b0c on fix-matplotlib-backend into 73566d96a93e77c18c5e0511db6d7e6df26ded1c on develop.

jreades commented 4 years ago

When is this due for release on to master? I'm just trying to update my docker image for next year's teaching and would love to have this fix available to install/update via the main conda-forge channel or pip. Or is there a dev tag that should use?

Thanks!

smmaurer commented 4 years ago

Hi @jreades, thanks for the reminder! This should be released next week. You can follow progress in issue #139.