[v0.5.1] Patch restoring get_node_ids() performance - Githubissues

UDST / pandana

Pandas Network Analysis by UrbanSim: fast accessibility metrics and shortest paths, using contraction hierarchies :world_map:

http://udst.github.io/pandana

GNU Affero General Public License v3.0

385 stars 84 forks source link

[v0.5.1] Patch restoring get_node_ids() performance #143

Closed smmaurer closed 4 years ago

smmaurer commented 4 years ago

This PR fixes a performance regression in Pandana v0.5.

The network.get_node_ids() function had switched from using scikit-learn nearest neighbors to scipy nearest neighbors, to streamline dependencies. But it turns out the performance is bad when you scale up to hundreds of thousands of locations or more. Thanks @cvanoli for identifying this.

This PR switches it back to the prior implementation.

Release logistics:

[x] update versioning
[x] update change log
[x] update docs
[x] release on pip
[x] release on conda-forge

smmaurer commented 4 years ago

Travis still not showing up, but it passes: https://travis-ci.org/github/udst/pandana/builds/715342652