Remove the need of POI initialization call

UDST / pandana

Pandas Network Analysis by UrbanSim: fast accessibility metrics and shortest paths, using contraction hierarchies :world_map:

http://udst.github.io/pandana

GNU Affero General Public License v3.0

386 stars 84 forks source link

Remove the need of POI initialization call #85

Closed federicofernandez closed 7 years ago

federicofernandez commented 7 years ago

This PR removes the need to create an initial set of POIIndex entries.

To achieve that, the POIIndex data structure was converted to a std::map with std::string keys.

The init_pois function is still in place because it's also used to define the max_dist and max_pois parameters. We should decide soon if we want to move those definitions to another method.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 90.964% when pulling 39a7f10b73e474074e953a0e3f1bcdea150aab2c on pois-string-keys into 437801a6703bb695e22b990967b78d2fa24138dd on cython.

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 90.891% when pulling 0e6115282bfcb05f2743fca63ed6544d7e92fdf9 on pois-string-keys into 437801a6703bb695e22b990967b78d2fa24138dd on cython.

federicofernandez commented 7 years ago

Sounds like a great idea, and easy to implement. I'll add that to this PR.

fscottfoti commented 7 years ago

cool - I'm ready to merge on this one (after the tests pass) and then will open a PR into master. Any reason not to?

federicofernandez commented 7 years ago

The only missing piece from my point of view is to update documentation. I'm beginning to work on that.

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 90.891% when pulling 30a6ac578942ec1debacffca53c0121b15e1a411 on pois-string-keys into 437801a6703bb695e22b990967b78d2fa24138dd on cython.

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 90.891% when pulling 66d094b0b43ba621deb36c5ccc746189de52e372 on pois-string-keys into 437801a6703bb695e22b990967b78d2fa24138dd on cython.

federicofernandez commented 7 years ago

@fscottfoti Could you review a bit the brief changes in documentation and let me know if I should do further changes? If it's not the case, I think we are ready to merge everything and release v0.4.0.

coveralls commented 7 years ago

Coverage decreased (-0.3%) to 90.891% when pulling 884ed6df56dc452329f3baf61edc262c9c3e6a1c on pois-string-keys into 437801a6703bb695e22b990967b78d2fa24138dd on cython.