search

UDST / synthpop

Synthetic populations from census data
BSD 3-Clause "New" or "Revised" License
99 stars 47 forks source link

Update helpers to run demos #41

Closed cvanoli closed 6 years ago

cvanoli commented 6 years ago

acs.get function variables updated

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 82.885% when pulling ceeda6b122cce39197169b672a0662c4a3c19bc2 on cvanoli:patch-1 into 24b68deeae1ede74bbb75db29de8d40fbf9396bd on UDST:master.

janowicz commented 6 years ago

Thanks @cvanoli! Could you describe a bit why this change was needed? Has the census library api changed? If a year argument is not supplied, what ACS vintage gets used?

cvanoli commented 6 years ago

I have read again the documentation. If no year variable is defined, the default year is 2016. The problem with the code is that the default year variable that is pulled inside the query function which contains the "get" function is set to None. The "get" function returns an error when a year = None. Therefore, in the "_query" function, the default value for the field year should be 2016 as it is in the package.

On Thu, Mar 1, 2018 at 7:51 PM, Eddie Janowicz notifications@github.com wrote:

Thanks @cvanoli https://github.com/cvanoli! Could you describe a bit why this change was needed? Has the census library api changed? If a year argument is not supplied, what ACS vintage gets used?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/UDST/synthpop/pull/41#issuecomment-369759004, or mute the thread https://github.com/notifications/unsubscribe-auth/Acfv10f4BUm5t5SV0p_sTZDJu-AKhH_Yks5taHt-gaJpZM4SYyo8 .

-- Catalina Vanoli Masters in Transportation Engineering University of California, Berkeley catalinavanoli@berkeley.edu catalinavanoli@berkeley.edu