search

UDST / urbanaccess

A tool for GTFS transit and OSM pedestrian network accessibility analysis by UrbanSim
https://udst.github.io/urbanaccess/index.html
GNU Affero General Public License v3.0
236 stars 56 forks source link

Provide Dockerfile #18

Open kuanb opened 7 years ago

kuanb commented 7 years ago

Note, relates to Issue: https://github.com/UDST/urbanaccess/issues/12

Dockerfile provides a clean, consistent environment for development and execution of library.

Making it available if desired. :)

kuanb commented 7 years ago

Not to rope @jalessio into this 😃 , but v helpful critique of this Dockerfile. Will revisit and make edits (again, just should anyone find this of use):

  1. "too many layers
 consolidate all those multiline commands into a single RUN like you have for the GEO libraries. Also, running apt-get update and apt-get install in separate RUN commands is a bit of an anti-pattern for a Dockerfile"

  2. "also, I think you’re doing the “cleanup” step too early in the process — you should so that at the end, since the apt commands you run for GEOS will just re-populate /var/lib/apt"