UDST / urbanaccess

A tool for GTFS transit and OSM pedestrian network accessibility analysis by UrbanSim
https://udst.github.io/urbanaccess/index.html
GNU Affero General Public License v3.0
239 stars 57 forks source link

Why sklearn vs scikit-learn? #27

Closed kuanb closed 7 years ago

kuanb commented 7 years ago

[Ques] According to the package page, one should use scikit-learn, rather than sklearn. Is there a specific reason why sklearn is being used, instead?

Ref: https://pypi.python.org/pypi/sklearn/0.0

pksohn commented 7 years ago

Hey Kuan, The list of required packages in setup.py refers to the right package, scikit-learn. The import syntax just uses the shortened name, sklearn, as seen in the quick start guide.

Closing this for now - let us know if there's something we missed here.

kuanb commented 7 years ago

Ah I see it was updated a few days ago: https://github.com/UDST/urbanaccess/commit/ff1cfe91c096f2e9c3622733486436cea62aa3ae

I had not pulled the latest commits to master. Prior to that commit, looks like the lib was indeed using sklearn vs. scikit-learn. Since the author is listed as "Unknown", I had thought that perhaps you guys had set that up as a sort of proxy to scikit-learn and was wondering why that was done (if that was the case).

pksohn commented 7 years ago

Ah, that makes sense :)