This PR contains updates to provide Python 3 compatibility.
Most of the codebase is fine; we're already using cross-version syntax for print statements, errors, and integer division.
Changes
Replaces urllib2.urlopen with the six.moves version, which automatically maps appropriately onto Python 2.7 and 3.x
Replaces .dict[] lookup of urlopen().info() results with .get()
Disables text encoding checks for Python 3 (general solution for detecting encodings will be in a future PR)
Updates some syntax in the demo notebook
Updates the setup script and Travis script for Python 3
Testing
I've been testing these changes locally using the demo notebook, in Python 2.7 and 3.6.
This is what the notebook output looks like: py2.7, py3.6.
The Travis script is updated to run the existing unit tests (minimal), demo notebook, and integration tests in Python 2.7, 3.5, and 3.6 (Travis doesn't support 3.7 smoothly yet).
UrbanAccess still requires Pandana v0.3; will add support for v0.4 in a separate PR.
Outstanding issues
The last three cells of the demo notebook, with Pandana plot commands, won't run on my machine either before or after this PR. They cause the kernel to die. (Mac OS 10.14, 32 GB RAM, Pandana 0.3, tried both Python 2.7 + Matplotlib 2 and Python 3.6 + Matplotlib 3.)
In Travis, it runs in Python 2.7 and often fails in Python 3. I am commenting out the code in these cells for the time being. (This is mostly resolved with Pandana 0.4; see PR #46.)
Versioning
This PR is labeled 0.2.dev1 in setup.py and the top-level __init__.py
This PR contains updates to provide Python 3 compatibility.
Most of the codebase is fine; we're already using cross-version syntax for print statements, errors, and integer division.
Changes
Replaces
urllib2.urlopenwith thesix.movesversion, which automatically maps appropriately onto Python 2.7 and 3.xReplaces
.dict[]lookup ofurlopen().info()results with.get()Disables text encoding checks for Python 3 (general solution for detecting encodings will be in a future PR)
Updates some syntax in the demo notebook
Updates the setup script and Travis script for Python 3
Testing
I've been testing these changes locally using the demo notebook, in Python 2.7 and 3.6.
This is what the notebook output looks like: py2.7, py3.6.
The Travis script is updated to run the existing unit tests (minimal), demo notebook, and integration tests in Python 2.7, 3.5, and 3.6 (Travis doesn't support 3.7 smoothly yet).
UrbanAccess still requires Pandana v0.3; will add support for v0.4 in a separate PR.
Outstanding issues
The last three cells of the demo notebook, with Pandana plot commands, won't run on my machine either before or after this PR. They cause the kernel to die. (Mac OS 10.14, 32 GB RAM, Pandana 0.3, tried both Python 2.7 + Matplotlib 2 and Python 3.6 + Matplotlib 3.)
In Travis, it runs in Python 2.7 and often fails in Python 3. I am commenting out the code in these cells for the time being. (This is mostly resolved with Pandana 0.4; see PR #46.)
Versioning
This PR is labeled
0.2.dev1insetup.pyand the top-level__init__.py