search

UDST / urbanaccess

A tool for GTFS transit and OSM pedestrian network accessibility analysis by UrbanSim
https://udst.github.io/urbanaccess/index.html
GNU Affero General Public License v3.0
236 stars 56 forks source link

Geopy fix #62

Closed knaaptime closed 4 years ago

knaaptime commented 4 years ago

geopy version 2 is out, so this resolves #53

smmaurer commented 4 years ago

Hi @knaaptime, thanks so much for this! And apologies for the slow response.

Substantively it looks perfect. Could you make a couple of formatting changes so that the pycodestyle tests pass?

  1. change <2 to < 2 in L12

  2. add one space to the indentation in L391

The Travis tests are running but are not showing up in GitHub for some reason: https://travis-ci.org/github/UDST/urbanaccess/builds/703587869

As far as I can tell, all the other errors are related to the OSMNet issue, so I think we can go ahead with merging and releasing this in parallel. cc @sablanchard

knaaptime commented 4 years ago

i can tack a fix for #60 onto this as well if its of interest? (the deperecation period is over so this raises a breaking error now)

sablanchard commented 4 years ago

Hi @knaaptime ! Responding to this: https://github.com/UDST/urbanaccess/pull/62#issuecomment-662165209 yes that would be great to also have a fix for that if you are interested in doing so. Instead of including it in this PR can you open a new PR for just that fix?

knaaptime commented 4 years ago

cool, will do

sablanchard commented 4 years ago

Hi @knaaptime @cvanoli has just made a PR to fix the depreciation issue here: https://github.com/UDST/urbanaccess/pull/65