UDST / urbansim_templates

Building blocks for simulation models
https://udst.github.io/urbansim_templates
BSD 3-Clause "New" or "Revised" License
20 stars 13 forks source link

Missing imports when using urbansim_templates from outside #127

Open gfourcade opened 2 years ago

gfourcade commented 2 years ago

It is necessary to include this code in some simulations for them to work with urbansim_templates. It should not be the responsibility of other modules to include an internal part of templates This should be addressed on this repository.

from urbansim.models import util
from urbansim_templates import modelmanager as mm
from urbansim_templates.models import OLSRegressionStep

https://github.com/UDST/urbansim_templates/blob/723b83b4187da53a50ee03fdba4842a464f68240/urbansim_templates/models/regression.py#L17

smmaurer commented 2 years ago

Hi, thanks for raising this @gfourcade @sablanchard @msoltadeo!

Could someone share with me one of the original log files showing an error coming from urbansim_templates? I looked through the material in the other issue and there isn't enough for me to know how exactly to resolve it..