Rewrite build.py -> release.py and fix bugs

UE4SS-RE / RE-UE4SS

Injectable LUA scripting system, SDK generator, live property editor and other dumping utilities for UE4/5 games

http://docs.ue4ss.com/

MIT License

1.38k stars 188 forks source link

Rewrite build.py -> release.py and fix bugs #542

Closed Buckminsterfullerene02 closed 5 months ago

Buckminsterfullerene02 commented 6 months ago

Description

Fixes the outstanding bugs currently in main. Rewritten for readability. Some extra error handling, adds concurrency groups to actions for more robustness, as currently the action fails in a potentially bad way when multiple are executed in a row (such as multiple merges happening in a flurry).

Fixes #538 Fixes #539

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Local testing:

Zip files match as expected
Tested case when kismetdebugger compiled
Tested case when kismetdebugger not compiled

Release:

Zip files match as expected

Checklist

[x] I have commented my code, particularly in hard-to-understand areas.

narknon commented 6 months ago

Release version mods.txt including the cpp mods that aren't included in release is intended, in case release and dev zips get mixed together without overwriting mods.txt

bitonality commented 6 months ago

Release version mods.txt including the cpp mods that aren't included in release is intended, in case release and dev zips get mixed together without overwriting mods.txt

Was not aware that this was the intended behavior - redacting my previous statement that indicated the correct behavior is restored.

bitonality commented 6 months ago

https://github.com/UE4SS-RE/RE-UE4SS/issues/543

Adding this for tracking purposes, but the completion of this PR should not qualify as the full fledged fix for #543

Buckminsterfullerene02 commented 6 months ago

release.py's git history is restored now

bitonality commented 6 months ago

Need to see the github concurrency setting added to the workflow files + python version locked down before I personally approve. Rest of the comments are nice if you get to them, but not necessarily worth blocking for.

Buckminsterfullerene02 commented 6 months ago

@narknon do you want to do final check of the output files? Release is -124-ge0fe418

narknon commented 6 months ago

Output looks good. Do we still have the bug with the first line of mods.txt not activating mods? Maybe it was fixed with the json switch?

Buckminsterfullerene02 commented 6 months ago

Output looks good. Do we still have the bug with the first line of mods.txt not activating mods? Maybe it was fixed with the json switch?

I don't know but that's out of scope of this PR anyway.