fix: Mod directory being used before it's setup

UE4SS-RE / RE-UE4SS

Injectable LUA scripting system, SDK generator, live property editor and other dumping utilities for UE4/5 games

http://docs.ue4ss.com/

MIT License

1.36k stars 185 forks source link

fix: Mod directory being used before it's setup #609

Closed UE4SS closed 3 months ago

UE4SS commented 3 months ago

Description

This fixes ModsFolderPath in UE4SS-settings.ini being broken.

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Move Binaries/Win64/Mods to ~~Binaries/Mods~~Content/Paks/Mods, and set ModsFolderPath to ../../Content/Paks/Mods.

Checklist

Please delete options that are not relevant. Update the list as the PR progresses.

[x] I have added the necessary description of this PR to the changelog, and I have followed the same format as other entries.

github-actions[bot] commented 3 months ago

Build Details

|Name|Information| |---|---| |PR Commit|54d64494fbce1cdeeb101307e65a58a3dbb4d603| |Merge Commit|955f82e57b70248c22b75aec8183730022478945| |Size|42.82 MB| |Last Updated|Aug 5, 24, 10:53:57 PM UTC| |Expires At|Aug 19, 24, 10:53:53 PM UTC|

Build Details

|Name|Information| |---|---| |PR Commit|54d64494fbce1cdeeb101307e65a58a3dbb4d603| |Merge Commit|955f82e57b70248c22b75aec8183730022478945| |Size|26.01 MB| |Last Updated|Aug 5, 24, 10:54:42 PM UTC| |Expires At|Aug 19, 24, 10:54:39 PM UTC|

Buckminsterfullerene02 commented 3 months ago

This does not work for me. And your test case seems weird as Mods are in Binaries/Win64/ue4ss/Mods. If I set mine to ../../Mods and move Mods into Binaries/Mods it does not find mods and there is no error.

Default directory is <UE4SS.dll directory>/Mods. I tested moving Mods into Content/Paks folder and set override path config to ../../Content/Paks/Mods, it doesn't find mods and there is no error. If I set it to ../../../Content/Paks/Mods I get Error: directory_iterator::directory_iterator: unknown error: "../../../Content/Paks/Mods". The latter is the correct path.

I do not have any override.txt file.

UE4SS commented 3 months ago

This does not work for me. And your test case seems weird as Mods are in Binaries/Win64/ue4ss/Mods. If I set mine to ../../Mods and move Mods into Binaries/Mods it does not find mods and there is no error.

Default directory is <UE4SS.dll directory>/Mods. I tested moving Mods into Content/Paks folder and set override path config to ../../Content/Paks/Mods, it doesn't find mods and there is no error. If I set it to ../../../Content/Paks/Mods I get Error: directory_iterator::directory_iterator: unknown error: "../../../Content/Paks/Mods". The latter is the correct path.

I do not have any override.txt file.

Okay obviously I typo'd it, I meant to say that I moved Mods into Content/Paks. As far as that error, the path is from the Win64 dir, not the ue4ss dir.

UE4SS commented 3 months ago

Note that there's another problem with the mod directory override that I'm currently working on. I'll update this PR.

UE4SS commented 3 months ago

This is now ready for testing again.

UE4SS commented 3 months ago

I've updated my test-case, sorry again for messing that up.