Players sometimes wrongly show as not played for a round

UEWBot / dipvis

Django-based visualiser for tournaments for the boardgame Diplomacy

GNU General Public License v3.0

7 stars 5 forks source link

Players sometimes wrongly show as not played for a round #211

Closed UEWBot closed 2 years ago

UEWBot commented 2 years ago

VDC 2021, round 3, Karthik was substituted into a game. Standings give him a score and a "did not play" asterisk. Spencer, who he replaced, has 0 but no asterisk. I suspect that the RoundPlayer.game_counts don't get updated it the games are changed.

UEWBot commented 2 years ago

This happened in Virtual Cascadia 2022. Jerry Fest was a standby player who played, but got the asterisk. I think that's because I went back into the roll call after seeding the games (to add a player I missed). The roll call page will reset RoundPlayer.game_count. Ideally, the asterisk should probably be determined by whether a GamePlayer exists, not by RoundPlayer.game_count. Let's keep the latter for use by the seeding algorithm.

UEWBot commented 2 years ago

Need to check all usage of RoundPlayer.game_count:

utils.fix_round_players() looks dubious.
Same for RScoringBest.scores().
Should probably update RoundPlayer.game_count.help_text.
tournament_views.tournament_scores() shouldn't use it.

UEWBot commented 2 years ago

Should be fixed now