search

UEWBot / dipvis

Django-based visualiser for tournaments for the boardgame Diplomacy
GNU General Public License v3.0
7 stars 5 forks source link

Some tests are skipped due to duplicate names #217

Closed code-review-doctor closed 2 years ago

code-review-doctor commented 2 years ago

Test names must be unique per scope otherwise the second test overrides the first one with the same name.

For example if you had a test file that does:

def test_a():
    pass

def test_a():
    pass

Then only the second test_a will be ran. More details here.

These are the tests that are overriding previously defined tests due to this problem:

https://github.com/UEWBot/dipvis/blob/262b1be684f5a1dcae082e9417496937b0d26a52/visualiser/tournament/test_game_seeder.py#L715 https://github.com/UEWBot/dipvis/blob/262b1be684f5a1dcae082e9417496937b0d26a52/visualiser/tournament/test_forms.py#L280

I found this issue automatically, see other issues here