search

UEWBot / dipvis

Django-based visualiser for tournaments for the boardgame Diplomacy
GNU General Public License v3.0
7 stars 5 forks source link

Some tests are skipped due to duplicate names fix #218

Closed code-review-doctor closed 2 years ago

code-review-doctor commented 2 years ago

Fixes #217.

These tests were overriding other tests in the same file with the same name. I renamed so the tests run. Please give the tests a better name than I used. Naming is hard and I'm just a bot :)

This might result in tests failing because the affected tests were previously not running.

UEWBot commented 2 years ago

The game seeding test fails, revealing a bug. The seeding algorithm doesn't actually keep players who are both playing two games apart. I think we need to add bias for each pairing of players playing two games to fix this.